Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend "feast in production" page with description of java feature server #2017

Merged
merged 39 commits into from Dec 1, 2021
Merged

Extend "feast in production" page with description of java feature server #2017

merged 39 commits into from Dec 1, 2021

Conversation

pyalex
Copy link
Collaborator

@pyalex pyalex commented Nov 11, 2021 •
edited

Signed-off-by: pyalex moskalenko.alexey@gmail.com

What this PR does / why we need it:

This PR extends "Running Feast in production" page in documentation.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2021 •
edited

Codecov Report

Merging #2017 (5198acc) into master (0356181) will decrease coverage by 25.19%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2017       +/-   ##
===========================================
- Coverage   83.30%   58.10%   -25.20%     
===========================================
  Files         100      100               
  Lines        8072     8077        +5     
===========================================
- Hits         6724     4693     -2031     
- Misses       1348     3384     +2036
Flag Coverage Δ
integrationtests ?
unittests 58.10% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../integration/online_store/test_online_retrieval.py 17.39% <0.00%> (-82.61%) ⬇️
.../integration/online_store/test_universal_online.py 15.34% <0.00%> (-82.33%) ⬇️
...fline_store/test_universal_historical_retrieval.py 19.29% <0.00%> (-80.12%) ⬇️
sdk/python/tests/utils/online_read_write_test.py 20.68% <0.00%> (-79.32%) ⬇️
...gration/registration/test_feature_service_apply.py 31.25% <0.00%> (-68.75%) ⬇️
sdk/python/feast/infra/online_stores/redis.py 26.97% <0.00%> (-67.11%) ⬇️
sdk/python/tests/data/data_creator.py 34.78% <0.00%> (-65.22%) ⬇️
sdk/python/tests/integration/e2e/test_usage_e2e.py 35.00% <0.00%> (-65.00%) ⬇️
...s/integration/registration/test_universal_types.py 36.73% <0.00%> (-63.27%) ⬇️
...istration/test_universal_odfv_feature_inference.py 38.29% <0.00%> (-61.71%) ⬇️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0356181...5198acc. Read the comment docs.

@pyalex pyalex changed the title Extend "feast in production" page with description of java feature server [WIP] Extend "feast in production" page with description of java feature server Nov 11, 2021
@adchia adchia self-assigned this Nov 12, 2021
@pyalex pyalex changed the title [WIP] Extend "feast in production" page with description of java feature server Extend "feast in production" page with description of java feature server Nov 17, 2021
@pyalex pyalex mentioned this pull request Nov 18, 2021
Merged
achals
achals approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot feast-ci-bot removed the lgtm label Nov 18, 2021
pyalex and others added 17 commits November 24, 2021 18:14
@pyalex @adchia
Update docs/how-to-guides/running-feast-in-production.md
15951bf 
Co-authored-by: Danny Chiao <d.chiao@gmail.com>
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
@pyalex @adchia
Update docs/how-to-guides/running-feast-in-production.md
2ed53da 
Co-authored-by: Danny Chiao <d.chiao@gmail.com>
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
@pyalex @adchia
Update docs/how-to-guides/running-feast-in-production.md
6da7db6 
Co-authored-by: Danny Chiao <d.chiao@gmail.com>
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
@pyalex @adchia
Update docs/how-to-guides/running-feast-in-production.md
f8de889 
Co-authored-by: Danny Chiao <d.chiao@gmail.com>
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
@pyalex
capital letters
a54a62a 
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
@pyalex @adchia
Update docs/how-to-guides/running-feast-in-production.md
71c4cf2 
Co-authored-by: Danny Chiao <d.chiao@gmail.com>
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
@pyalex @adchia
Update docs/how-to-guides/running-feast-in-production.md
de5471c 
Co-authored-by: Danny Chiao <d.chiao@gmail.com>
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
@pyalex @adchia
Update docs/how-to-guides/running-feast-in-production.md
b1cbc5f 
Co-authored-by: Danny Chiao <d.chiao@gmail.com>
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
@pyalex @adchia
Update docs/how-to-guides/running-feast-in-production.md
613a7da 
Co-authored-by: Danny Chiao <d.chiao@gmail.com>
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
@pyalex @adchia
Update docs/how-to-guides/running-feast-in-production.md
f861d4c 
Co-authored-by: Danny Chiao <d.chiao@gmail.com>
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
@pyalex @adchia
Update docs/how-to-guides/running-feast-in-production.md
c64e9f0 
Co-authored-by: Danny Chiao <d.chiao@gmail.com>
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
@pyalex @adchia
Update docs/how-to-guides/running-feast-in-production.md
5efab15 
Co-authored-by: Danny Chiao <d.chiao@gmail.com>
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
@pyalex @woop
Update docs/how-to-guides/running-feast-in-production.md
1442ed8 
Co-authored-by: Willem Pienaar <6728866+woop@users.noreply.github.com>
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
@pyalex @woop
Update docs/how-to-guides/running-feast-in-production.md
689ee72 
Co-authored-by: Willem Pienaar <6728866+woop@users.noreply.github.com>
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
@pyalex @woop
Update docs/how-to-guides/running-feast-in-production.md
aea227e 
Co-authored-by: Willem Pienaar <6728866+woop@users.noreply.github.com>
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
@pyalex @woop
Update docs/how-to-guides/running-feast-in-production.md
679b759 
Co-authored-by: Willem Pienaar <6728866+woop@users.noreply.github.com>
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
@pyalex
more edits
8a57cf4 
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
adchia
adchia requested changes Nov 28, 2021
View reviewed changes
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

docs/how-to-guides/running-feast-in-production.md Outdated Show resolved Hide resolved
docs/how-to-guides/running-feast-in-production.md Outdated Show resolved Hide resolved
@pyalex
address more comments
5198acc 
Signed-off-by: pyalex <moskalenko.alexey@gmail.com>
@feast-ci-bot feast-ci-bot removed the lgtm label Nov 29, 2021
@pyalex pyalex added lgtm and removed lgtm labels Nov 29, 2021
@pyalex pyalex requested a review from adchia December 1, 2021 16:08
adchia
adchia approved these changes Dec 1, 2021
View reviewed changes
Copy link
Collaborator

@adchia adchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit 455176f into feast-dev:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woop woop woop left review comments

@tedhtchang tedhtchang tedhtchang left review comments

@achals achals achals approved these changes

@adchia adchia adchia approved these changes

@felixwang9817 felixwang9817 Awaiting requested review from felixwang9817

@tsotnet tsotnet Awaiting requested review from tsotnet

Assignees

@achals achals

@adchia adchia

@felixwang9817 felixwang9817

Labels
approved area/documentation lgtm release-note-none size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@pyalex @codecov-commenter @feast-ci-bot @achals @adchia @woop @tedhtchang @felixwang9817